🚧 Add spacing tokens #2579
Draft
🚧 Add spacing tokens #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turned out this was more than the Figma Tokens plugin could handle
vnys
force-pushed
the
feature/vnys-2575-spacing-tokens
branch
from
7bc887c
to
d628b52
Compare
It’s superfluous and sorts after 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autolayout container tokens for ensuring the calculated height is dividable with 4, and the baseline grid in the textframe is aligned with the layout grid.
Calculations in https://docs.google.com/spreadsheets/d/15l1D3FA-35b6hXrYrRupOH0uBu1P2Ukm28s3kqP1GJ0/edit?usp=sharing
There are some issues with referencing other tokens, so the paddingTop token is longer than it should need to be. I’ll ask for assistance in the Figma Tokens Slack channel on Monday, too busy with EqU today.
Example of 14px font-size on 16px line-height with a padding of 12px. Using the calculations from the spreadsheet gives us a paddingTop of 11px and a paddingBottom of 9px which lands the baseline grid on the third gridline from the bottom of the frame.
The next step is scripting the generation of the scales to avoid time consuming and error prone manual work.
See the Figma branch for more info.
resolves #2575