Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛💄Menu: implement [popover] #3583

Merged
merged 5 commits into from
Aug 13, 2024
Merged

🐛💄Menu: implement [popover] #3583

merged 5 commits into from
Aug 13, 2024

Conversation

oddvernes
Copy link
Collaborator

@oddvernes oddvernes commented Aug 13, 2024 •
edited
Loading

resolves #3580

  • use popover attribute in menu
  • fix an issue where when Autocomplete is inside a Menu, options were unclickable
  • add missing role="group" to Menu.Section after jest axe test failed (I think the tests never rendered the full menu until i refactored it to use popover)

@oddvernes oddvernes merged commit 9365916 into develop Aug 13, 2024
6 checks passed
@oddvernes oddvernes deleted the OOVE/3580-autocomplete-in-menu branch August 13, 2024 10:00
@Noggling Noggling mentioned this pull request Sep 10, 2024
Open
@EdwardBrunton EdwardBrunton mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnys vnys Awaiting requested review from vnys vnys is a code owner

@torleifhalseth torleifhalseth Awaiting requested review from torleifhalseth torleifhalseth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocomplete inside Menu unusable since @equinor/eds-core-react 0.38
1 participant
@oddvernes