Run from cli #562
Merged
Run from cli #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR makes it so that instead of starting ISAR with 'python main.py', the application is started with the cli command 'isar'. I suggest the next releast to be a minor bump (1.20.0) to emphasis this change. |
aeshub
reviewed
Jun 4, 2024
Comment on lines
+1
to
+2
| # This file is added for backwards-compability for versions 1.19.2 and older. | ||
| # It can be removed in the next minor bump (1.20.0) |
There was a problem hiding this comment.
If this file is removed the Dockerfile implementation will break as this runs main.py directly. Is there a solution to tell Docker to run this cli command?
There was a problem hiding this comment.
Yes, that is the idea. i want to remove the Dockerfile and image altogether from ISAR and just build it from isar-robot (and the other sup-repos). Those already have isar available as the library and does not need the isar image
this can be removed in next minor bump of version (1.20.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.