Extended scheduled job status messages #603
Conversation
|
…b-status # Conflicts: # go.mod # go.sum
| eventList, err := kubequery.GetEventsForEnvironment(ctx, kubeClient, appName, deployment.Environment) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| lastEventWarnings := event.ConvertToEventWarnings(eventList) | ||
| replicaSummaryList = getReplicaSummaryList(componentPods, lastEventWarnings) |
There was a problem hiding this comment.
Not sure how useful it is to include the last warning event. There can be multiple warning events, and only showing the last will potentially hide other important events. Perhaps a better approach is to have an endpoint for the component and/or replica that returns events for the particular object. We can then show it in web console as an event list, similar to the event list on the environment page
There was a problem hiding this comment.
Alternative can be to show events within the replica page, but it will not show the rootcause of some issues with replica after it was deleted
| if len(replicaSummary.StatusMessage) == 0 && (replicaSummary.Status.Status == Failing.String() || replicaSummary.Status.Status == Pending.String()) { | ||
| replicaSummary.StatusMessage = lastEventWarning |
There was a problem hiding this comment.
Not sure its a good idea to set last warning event in StatusMessage. We should instead discuss if we shall show events per component and/or replica, as described in my other comment
There was a problem hiding this comment.
Same reason as above - to keep the failure reason in the radix-batch status, when replicas and events do not longer exist
No description provided.