Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade horizontal scaling information (Keda) #633

Merged
merged 25 commits into from
Jun 14, 2024

Conversation

Richard87
Copy link
Contributor

@Richard87 Richard87 commented Jun 10, 2024

Example response:

Note: Limitations in Keda status/hpa status fields causes resource types to match on the first type (so the code below will be invalid for duplicate cpu and memory triggers (only the first of each type is correct, the other is duplicated)

        "horizontalScalingSummary": {
          "minReplicas": 1,
          "maxReplicas": 3,
          "cooldownPeriod": 300,
          "pollingInterval": 30,
          "triggers": [
            {
              "name": "cpu4",
              "current_utilization": "1",
              "target_utilization": "50",
              "type": "cpu"
            },
            {
              "name": "cpu4",
              "current_utilization": "1",
              "target_utilization": "50",
              "type": "cpu"
            },
            {
              "name": "memory2",
              "current_utilization": "11",
              "target_utilization": "50",
              "type": "memory"
            },
            {
              "name": "cron",
              "current_utilization": "1",
              "target_utilization": "1",
              "type": "cron"
            },
            {
              "name": "azuresb",
              "current_utilization": "",
              "target_utilization": "10",
              "type": "azure-servicebus",
              "error": "Failing: number of failurs: 7020"
            }
          ],
          "currentCPUUtilizationPercentage": 1,
          "targetCPUUtilizationPercentage": 50,
          "currentMemoryUtilizationPercentage": 11,
          "targetMemoryUtilizationPercentage": 50
        },

@Richard87 Richard87 self-assigned this Jun 10, 2024
@Richard87 Richard87 changed the title Update operator with keda support Upgrade horizontal scaling information (Keda) Jun 10, 2024
@Richard87 Richard87 marked this pull request as ready for review June 13, 2024 09:59
Copy link
Contributor

@nilsgstrabo nilsgstrabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions

// Component current average CPU utilization over all pods, represented as a percentage of requested CPU
//
// required: false
// example: 70
// deprecated: use Triggers instead. Will be removed from Radix API 2025-01-01.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecated "annotation" is not propagated to swagger.json (if that was the intention), nor does it flag it as deprecated to the linters.
Applies to the next three field

api/deployments/component_handler.go Outdated Show resolved Hide resolved
api/environments/environment_handler.go Outdated Show resolved Hide resolved
api/environments/environment_handler.go Outdated Show resolved Hide resolved
api/environments/utils.go Outdated Show resolved Hide resolved
api/utils/logs/roundtrip_logger.go Outdated Show resolved Hide resolved
api/utils/kubernetes.go Show resolved Hide resolved
api/utils/kubernetes.go Show resolved Hide resolved
Richard87 and others added 2 commits June 14, 2024 11:16
Co-authored-by: Nils Gustav Stråbø <65334626+nilsgstrabo@users.noreply.github.com>
Co-authored-by: Nils Gustav Stråbø <65334626+nilsgstrabo@users.noreply.github.com>
@Richard87 Richard87 merged commit 0e583c9 into master Jun 14, 2024
7 checks passed
@Richard87 Richard87 deleted the update-operator-with-keda-support branch June 14, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants