Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client-only tags in direct PRIVMSG are not replayed unless the client has draft/event-playback #1411

Closed
slingamn opened this issue Nov 30, 2020 · 1 comment
Closed

client-only tags in direct PRIVMSG are not replayed unless the client has draft/event-playback #1411

slingamn opened this issue Nov 30, 2020 · 1 comment
Labels
bug
Milestone
v2.5

Comments

@slingamn
Copy link
Member

This is a bug in #1044 / 2f20034. The patch correctly requires draft/event-playback for playback of TAGMSG, but incorrectly requires it for client-only tags on ordinary PRIVMSG.

This needs an irctest.
@slingamn slingamn added the bug label Nov 30, 2020
@slingamn slingamn added this to the v2.5 milestone Nov 30, 2020
@slingamn slingamn changed the title client-only tags are not replayed unless the client has draft/event-playback client-only tags in direct PRIVMSG are not replayed unless the client has draft/event-playback Nov 30, 2020
@slingamn
Copy link
Member Author

This only applies to DMs.

slingamn added a commit that referenced this issue Nov 30, 2020
@slingamn
fix #1411
24ba461 
Clients without event-playback should receive client-only tags in
replayed PRIVMSG / NOTICE.
slingamn added a commit that referenced this issue Nov 30, 2020
@slingamn
Merge pull request #1413 from slingamn/issue1411_dmtags
0e47076 
fix #1411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.5
Development

No branches or pull requests
1 participant
@slingamn