Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql is broken on 32-bit architectures #1969

Closed
slingamn opened this issue Jun 10, 2022 · 1 comment
Closed

mysql is broken on 32-bit architectures #1969

slingamn opened this issue Jun 10, 2022 · 1 comment
Labels
bug
Milestone
v2.11

Comments

@slingamn
Copy link
Member

Reported by hauser in the support channel:

2022-06-10T12:11:54.847Z : info  : server     : ergo-2.10.0 starting
2022-06-10T12:11:54.847Z : info  : server     : Using config file : ircd.yaml
2022-06-10T12:11:54.848Z : info  : server     : Using datastore : ircd.db
panic: unaligned 64-bit atomic operation

goroutine 1 [running]:
runtime/internal/atomic.panicUnaligned()
	runtime/internal/atomic/unaligned.go:8 +0x24
runtime/internal/atomic.Store64(0x1dc6f54, 0xb2d05e00)
	runtime/internal/atomic/atomic_arm.s:291 +0x14
github.com/ergochat/ergo/irc/mysql.(*MySQL).SetConfig(0x1dc6f54, {0x1, {0x1d9b5a0, 0x9}, 0xcea, {0x0, 0x0}, {0x1d9b5c0, 0x4}, {0x1d9b5d0, ...}, ...})
	github.com/ergochat/ergo/irc/mysql/history.go:72 +0x30
github.com/ergochat/ergo/irc/mysql.(*MySQL).Initialize(...)
	github.com/ergochat/ergo/irc/mysql/history.go:68
github.com/ergochat/ergo/irc.(*Server).loadFromDatastore(0x1dc6dc0, 0x1cc5500)
	github.com/ergochat/ergo/irc/server.go:845 +0x1d0
github.com/ergochat/ergo/irc.(*Server).applyConfig(0x1dc6dc0, 0x1cc5500)
	github.com/ergochat/ergo/irc/server.go:714 +0xc24
github.com/ergochat/ergo/irc.NewServer(0x1cc5500, 0x1f97500)
	github.com/ergochat/ergo/irc/server.go:115 +0x3b8
main.main()
	./ergo.go:194 +0xe7c
@slingamn slingamn added the bug label Jun 10, 2022
@slingamn slingamn added this to the v2.11 milestone Jun 10, 2022
slingamn added a commit that referenced this issue Jun 10, 2022
@slingamn
Merge pull request #1970 from ergochat/devel+issue1969_alignment
c0e7aac 
fix #1969
@slingamn
Copy link
Member Author

This was ergo-2.10.0-linux-armv6.tar.gz running on a Raspberry Pi Zero 2 W with the armv7l kernel.

slingamn added a commit to slingamn/ergo that referenced this issue Aug 10, 2022
@slingamn
use new aligned atomic types everywhere
35128bf 
See 69448b1 / ergochat#1969; the compiler can now ensure that a uint64
intended for atomic access is always aligned to a 64-bit boundary.
Convert atomic operations on uint32s and pointers as well.
@slingamn slingamn mentioned this issue Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.11
Development

No branches or pull requests
1 participant
@slingamn