-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ergo sending BATCH
to the client without previous negotiation
#2066
Comments
Thanks! It looks like for normal chathistory subcommands ( Lines 224 to 233 in bf33fba
but I forgot to do it for TARGETS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
request
draft/chathistory
but do not requestbatch
Actual behavior
trimmed down a bit
Expected behavior
server should never send
BATCH
to the client because it was never requestedCode
As you can see in irc/handlers.go:657 batch is used without checking client's capabilities.
The text was updated successfully, but these errors were encountered: