Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweaks to websocket handling #2038

Merged
merged 3 commits into from
Jan 23, 2023
Merged

tweaks to websocket handling #2038

merged 3 commits into from
Jan 23, 2023

Conversation

slingamn
Copy link
Member

This is #2037 (an optimization) plus a correctness issue that should get a changelog entry.

@slingamn slingamn added this to the v2.12.0 milestone Jan 22, 2023
@slingamn
Copy link
Member Author

As a follow-up to #2039 I might consider doing an additional utf8.Valid check on all outgoing websocket messages. It's cheap, doesn't allocate, and provides defense in depth against issues like these.

@slingamn slingamn merged commit 5ecf19d into ergochat:master Jan 23, 2023
@slingamn slingamn mentioned this pull request Feb 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug performance
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@slingamn