allow to gracefully exit from CL downloading stage #10887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
currentStage.ActionFunc(sctx, lg, cfg, args): modify this line is clstages to use only ctx without context |
|
Should |
|
FYI: there is |
Giulio2002
approved these changes
Jun 27, 2024
|
this PR should work |
VBulikov
pushed a commit
that referenced
this pull request
Jul 4, 2024
There is comment that preferred way to use different context not bounded to general app context. But through it we propagate cancellations by signal. @Giulio2002 could you please clarify if we still need separated context or it's okay to pass ctx.
VBulikov
added a commit
that referenced
this pull request
Jul 4, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is comment that preferred way to use different context not bounded to general app context. But through it we propagate cancellations by signal. @Giulio2002 could you please clarify if we still need separated context or it's okay to pass ctx.
Closes #10573