Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turbo/jsonrpc: add optional includePrecompiles flag to trace_* apis #10979

Merged
merged 7 commits into from
Jul 4, 2024

Conversation

taratorio
Copy link
Member

relates to #9784

  • Adds support for an optional "includePrecompiles" tracer config option for our OeTracer (OpenEthereum) that users can use to match output of debug_* apis with callTracer (by default it includes precompiles). Note default spec for OpenEthereum traces are to not include precompiles - this is preserved by this PR
  • Note geth has support for "includePrecompiles" so we are getting more aligned as well - https://github.com/ethereum/go-ethereum/blob/master/eth/tracers/native/call_flat.go#L124
  • Adds tests for OeTracer

@taratorio taratorio changed the title Oe tracer incl precompiles flag turbo/jsonrpc: add optional includePrecompiles to trace_* apis Jul 2, 2024
@taratorio taratorio changed the title turbo/jsonrpc: add optional includePrecompiles to trace_* apis turbo/jsonrpc: add optional includePrecompiles flag to trace_* apis Jul 2, 2024
@taratorio taratorio added this to the 2.60.3-fixes milestone Jul 2, 2024
@VBulikov VBulikov merged commit 9710e98 into release/2.60 Jul 4, 2024
7 checks passed
@VBulikov VBulikov deleted the oe-tracer-incl-precompiles-flag branch July 4, 2024 09:07
taratorio added a commit that referenced this pull request Jul 4, 2024
…10979)

relates to #9784

- Adds support for an optional `"includePrecompiles"` tracer config
option for our OeTracer (OpenEthereum) that users can use to match
output of debug_* apis with callTracer (by default it includes
precompiles). Note default spec for OpenEthereum traces are to not
include precompiles - this is preserved by this PR
- Note geth has support for `"includePrecompiles"` so we are getting
more aligned as well -
https://github.com/ethereum/go-ethereum/blob/master/eth/tracers/native/call_flat.go#L124
- Adds tests for OeTracer
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants