Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HexOrDecimal - to accept unquoted numbers - in json (e2) #11264

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

AskAlexSharov
Copy link
Collaborator

accept in genesis.json: "nonce": 0,
now see:

Fatal: invalid genesis file: json: cannot unmarshal number into Go struct field Genesis.alloc of type *math.HexOrDecimal64

See also https://github.com/ethereum/go-ethereum/pull/26758

genesis := &types.Genesis{}
err = json.Unmarshal(genesisData, genesis)
require.NoError(t, err)
_ = genesisData
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add assertion?

@AskAlexSharov AskAlexSharov merged commit f6fcd01 into release/2.60 Jul 22, 2024
6 checks passed
@AskAlexSharov AskAlexSharov deleted the genesis_hex_e2 branch July 22, 2024 06:40
@yperbasis yperbasis added this to the 2.60.5-fixes milestone Jul 22, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants