Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matching data text as search text #141

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

sigmike
Copy link
Contributor

@sigmike sigmike commented Apr 20, 2017

The current implementation expects an object as value when there's a dataSourceConfig. But the value is usually just a value, not an object containing the value and the text. So I believe when a value is provided and there's a dataSourceConfig the corresponding text should be looked up in the dataSource.

Maybe the case where the value is actually an object should be handled too, but I'm not sure it's a valid use case since the current behavior on change is to set only the value in the form data.

@codecov-io
Copy link

codecov-io commented Apr 20, 2017

Codecov Report

Merging #141 into master will decrease coverage by 2.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   78.37%   76.31%   -2.07%     
==========================================
  Files          11       11              
  Lines          37       38       +1     
==========================================
  Hits           29       29              
- Misses          8        9       +1
Impacted Files Coverage Δ
src/AutoComplete.js 42.85% <0%> (-7.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ddf94...818744f. Read the comment docs.

@erikras
Copy link
Owner

erikras commented Apr 20, 2017

LGTM.

@erikras erikras merged commit 536508a into erikras:master Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants