Evi/fix svg inversion #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanvivien
force-pushed
the
evi/fix-svg-inversion
branch
2 times, most recently
from
152996e
to
278f28b
Compare
This is because I called commands with (x, y) instead of (y, x) Fixes #47
erwanvivien
force-pushed
the
evi/fix-svg-inversion
branch
from
278f28b
to
60174c1
Compare
|
Awesome, thanks for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue spoted by @Adam-Alj
I've added a test that assets it's working as intended, I'm also closing #48. The fix works but it's not the best fix
Thanks a lot Adam-Alj