Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document default_node_config options #3013

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

leszke
Copy link
Contributor

@leszke leszke commented Jan 19, 2021

I added one concise table documenting these options and their default values for each node plugin.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 19, 2021

9034.1 / Erlang 23.0.3 / small_tests / ffa8428
Reports root / small


9034.2 / Erlang 23.0.3 / internal_mnesia / ffa8428
Reports root/ big
OK: 1502 / Failed: 0 / User-skipped: 161 / Auto-skipped: 0


9034.3 / Erlang 23.0.3 / odbc_mssql_mnesia / ffa8428
Reports root/ big
OK: 2770 / Failed: 0 / User-skipped: 229 / Auto-skipped: 0


9034.4 / Erlang 23.0.3 / mysql_redis / ffa8428
Reports root/ big
OK: 2765 / Failed: 0 / User-skipped: 234 / Auto-skipped: 0


9034.7 / Erlang 23.0.3 / elasticsearch_and_cassandra_mnesia / ffa8428
Reports root/ big
OK: 331 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


9034.5 / Erlang 23.0.3 / riak_mnesia / ffa8428
Reports root/ big
OK: 1628 / Failed: 0 / User-skipped: 181 / Auto-skipped: 0


9034.6 / Erlang 23.0.3 / ldap_mnesia / ffa8428
Reports root/ big
OK: 1404 / Failed: 0 / User-skipped: 259 / Auto-skipped: 0


9034.9 / Erlang 22.3 / pgsql_mnesia / ffa8428
Reports root/ big / small
OK: 2783 / Failed: 0 / User-skipped: 216 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #3013 (1b22e20) into master (6171e56) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3013      +/-   ##
==========================================
+ Coverage   78.50%   78.53%   +0.02%     
==========================================
  Files         376      376              
  Lines       31502    31502              
==========================================
+ Hits        24732    24739       +7     
+ Misses       6770     6763       -7     
Impacted Files Coverage Δ
src/cassandra/mongoose_cassandra_worker.erl 73.11% <0.00%> (-1.89%) ⬇️
src/muc_light/mod_muc_light.erl 82.96% <0.00%> (-0.88%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 76.83% <0.00%> (-0.57%) ⬇️
src/mod_muc_log.erl 77.72% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 72.00% <0.00%> (+0.05%) ⬆️
src/mod_muc_room.erl 77.54% <0.00%> (+0.29%) ⬆️
src/ejabberd_sm.erl 76.07% <0.00%> (+0.30%) ⬆️
src/mod_bosh_socket.erl 78.88% <0.00%> (+1.24%) ⬆️
src/mod_bosh.erl 93.91% <0.00%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6171e56...1b22e20. Read the comment docs.

Copy link
Contributor

@janciesla8818 janciesla8818 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the changes.

@janciesla8818 janciesla8818 merged commit b532122 into master Jan 19, 2021
@janciesla8818 janciesla8818 deleted the document-default_node_config-options branch January 19, 2021 13:46
@leszke leszke added this to the 4.1.0 milestone Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants