Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored hook handlers in mod_muc #3854

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Refactored hook handlers in mod_muc #3854

merged 1 commit into from
Nov 21, 2022

Conversation

pawlooss1
Copy link
Member

This PR changes all hook handlers in mod_muc module to gen_hook format.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 10, 2022 •
edited
Loading

small_tests_24 / small_tests / 1e060e4
Reports root / small

small_tests_25 / small_tests / 1e060e4
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1e060e4
Reports root/ big
OK: 4026 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1e060e4
Reports root/ big
OK: 4025 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

service_mongoose_system_metrics_SUITE:module_opts:rdbms_module_opts_are_reported 
{error,
  {{assertEqual,
     [{module,service_mongoose_system_metrics_SUITE},
      {line,372},
      {expression,"is_module_opt_reported ( Module , Key , Value )"},
      {expected,true},
      {value,false}]},
   [{service_mongoose_system_metrics_SUITE,check_module_opt,3,
      [{file,
         "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
       {line,372}]},
    {service_mongoose_system_metrics_SUITE,rdbms_module_opts_are_reported,
      1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
       {line,238}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

ldap_mnesia_24 / ldap_mnesia / 1e060e4
Reports root/ big
OK: 2127 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 1e060e4
Reports root/ big
OK: 2127 / Failed: 0 / User-skipped: 784 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 1e060e4
Reports root/ big
OK: 3999 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

metrics_register_SUITE:registration:unregister 
{error,
  {{badmatch,
     {error,
       {connection_step_failed,
         {{escalus_session,authenticate},
          {client,<<"alicE@domain.example.com">>,escalus_tcp,
            <0.2755.2>,undefined,
            [{username,<<"alicE">>},
             {server,<<"domain.example.com">>},
             {host,<<"localhost">>},
             {port,5222},
             {auth,{escalus_auth,auth_plain}},
             {wspath,undefined},
             {username,<<"alicE">>},
             {server,<<"domain.example.com">>},
             {host,<<"localhost">>},
             {password,<<"matygrysa">>},
             {stream_id,<<"15ff87375f3386d3">>}]},
          [{compression,[<<"zlib">>]},
           {starttls,true},
           {stream_management,true},
           {advanced_message_processing,true},
           {client_state_indication,false},
           {sasl_mechanisms,[<<"SCRAM-SHA-256">>,<<"PLAIN">>]},
           {caps,undefined}]},
         {auth_failed,<<"alicE">>,
           {xmlel,<<"failure">>,
             [{<<"xmlns">>,
               <<"urn:ietf:params:xml:ns:xmpp-sasl">>}],
             [{xmlel,<<"not-authorized">>,[],[]}]}}}}},
   [{escalus_users,delete_user,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_users.erl"},
       {line,297}]},
    {metrics_register_SUITE,unregister,1,
      [{file,
         "/home/circleci/project/big_tests/tests/metrics_register_SUITE.erl"},
       {line,102}]},
    {test_server,ts_tc,3,[{file,"t...

Report log

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 1e060e4
Reports root/ big
OK: 4026 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 1e060e4
Reports root/ big
OK: 2263 / Failed: 0 / User-skipped: 648 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 1e060e4
Reports root/ big
OK: 4400 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 1e060e4
Reports root/ big
OK: 2605 / Failed: 0 / User-skipped: 641 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 1e060e4
Reports root/ big
OK: 4411 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2578@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2578@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"AFijJeLh1vdD4Tw1+/BjFw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / 1e060e4
Reports root/ big
OK: 4389 / Failed: 1 / User-skipped: 111 / Auto-skipped: 0

mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted 
{error,
  {{assertMatch,
     [{module,mod_event_pusher_rabbit_SUITE},
      {line,422},
      {expression,
        "get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
      {pattern,
        "# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
      {value,
        #{<<"from_user_id">> =>
          <<"muc_publish@muc.localhost/bob_unnamed_2185">>,
        <<"message">> => <<"Hi there!">>,
        <<"to_user_id">> =>
          <<"alice_unnamed_2186@localhost/res1">>}}]},
   [{mod_event_pusher_rabbit_SUITE,
      '-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
      [{file,
         "/home/circleci/project/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
       {line,422}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / 1e060e4
Reports root/ big
OK: 2451 / Failed: 0 / User-skipped: 627 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 1e060e4
Reports root/ big
OK: 4400 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1e060e4
Reports root/ big
OK: 4026 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 1e060e4
Reports root/ big
OK: 3999 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive 
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mysql_redis_25 / mysql_redis / 1e060e4
Reports root/ big
OK: 3999 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive 
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mysql_redis_25 / mysql_redis / 1e060e4
Reports root/ big
OK: 4000 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Nov 10, 2022 •
edited
Loading

Codecov Report

Base: 83.08% // Head: 83.07% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (1e060e4) compared to base (68efb98).
Patch coverage: 63.63% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3854      +/-   ##
==========================================
- Coverage   83.08%   83.07%   -0.02%     
==========================================
  Files         535      535              
  Lines       34118    34122       +4     
==========================================
- Hits        28348    28346       -2     
- Misses       5770     5776       +6
Impacted Files Coverage Δ
src/mod_muc.erl 74.24% <63.63%> (+<0.01%) ⬆️
src/inbox/mod_inbox_rdbms_async.erl 70.58% <0.00%> (-2.95%) ⬇️
src/pubsub/node_pep.erl 77.77% <0.00%> (-1.86%) ⬇️
src/rdbms/mongoose_rdbms.erl 65.26% <0.00%> (-1.06%) ⬇️
src/pubsub/mod_pubsub.erl 73.04% <0.00%> (-0.19%) ⬇️
src/auth/ejabberd_auth.erl 85.27% <0.00%> (+1.52%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 68.88% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pawlooss1 pawlooss1 marked this pull request as ready for review November 21, 2022 07:36
kamilwaz
kamilwaz approved these changes Nov 21, 2022
View reviewed changes
Copy link

@kamilwaz kamilwaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kamilwaz kamilwaz merged commit 0b93aa8 into master Nov 21, 2022
@kamilwaz kamilwaz deleted the hooks/mod_muc branch November 21, 2022 07:43
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilwaz kamilwaz kamilwaz approved these changes

@NelsonVides NelsonVides Awaiting requested review from NelsonVides

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pawlooss1 @mongoose-im @kamilwaz @chrzaszcz