Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore SpreadExpressions in no-only-tests and prefer-output-null #362

Closed
wants to merge 4 commits into from
Closed

Conversation

FloEdelmann
Copy link
Contributor

@FloEdelmann FloEdelmann commented Jul 18, 2023

Without this change, the rules error at spread expressions in rule tests. I've added test cases to reproduce the issue.

@FloEdelmann FloEdelmann changed the title Ignore SpreadExpressions in no-only-tests Ignore SpreadExpressions in no-only-tests and prefer-output-null Jul 18, 2023
Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add requested a review from bmish July 19, 2023 02:27
@aladdin-add
Copy link
Contributor

cherry-picked in 4924042.

@FloEdelmann FloEdelmann deleted the patch-3 branch July 19, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants