Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClockControl::max helper #701

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Add ClockControl::max helper #701

merged 4 commits into from
Aug 2, 2023

Conversation

MabezDev
Copy link
Member

Closes #698

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All examples work.
  • cargo fmt was run.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You updated existing examples or added examples (if applicable).
  • Added examples are checked in CI

Nice to have

  • You add a description of your work to this PR.
  • You added proper docs for your newly added features and code.

@bugadani
Copy link
Contributor

Is the #[allow(unused)] necessary on public API? 🤔

@MabezDev
Copy link
Member Author

Is the #[allow(unused)] necessary on public API? 🤔

Thanks, not sure why these were there in the first place, but I've removed them all now.

jessebraham
jessebraham approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham merged commit 2f09116 into esp-rs:main Aug 2, 2023
2 checks passed
@MabezDev MabezDev mentioned this pull request Aug 2, 2023
Closed
9 tasks
playfulFence pushed a commit to playfulFence/esp-hal that referenced this pull request Sep 26, 2023
@MabezDev @jessebraham @playfulFence
Add ClockControl::max helper (esp-rs#701)
f7292ce 
* Add `ClockControl::max` helper

* Add changelog

* remove unneeded allow(unused)

---------

Co-authored-by: Jesse Braham <jessebraham@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

@bjoernQ bjoernQ Awaiting requested review from bjoernQ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ClockControl::max convenience method
3 participants
@MabezDev @bugadani @jessebraham