revert: Changes Session back to own the socket #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done as a fix for the server, but it seems that letting T and simply passing &mut T fixes the original issue this PR was intended to fix. Other libraries like embedded_tls take ownership of the socket. This allows to move session around without having to keep a reference to the socket alive. Ref: c094cfc
|
I think the build fails because of the changes around atomics (not related to this PR). We probably need to update the HAL dependencies and remove the atomic-emulation configs from Code changes look good to me |
bjoernQ
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done as a fix for the server, but it seems that letting T and simply passing &mut T fixes the original issue this PR was intended to fix.
Other libraries like
embedded_tlstake ownership of the socket. This allows to move the session around without having to keep a reference to the socket alive.I've ran the justfile and everything compiles. This unblocks my fork of reqwless that attempts to use
esp-mbedtlsas a TLS wrapper (coming soon).Ref: c094cfc