Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embassy-net #289

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Update embassy-net #289

merged 1 commit into from
Nov 2, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 16, 2023

I've merged in Hailey's commit (#265) as it logically belongs here - this PR doesn't compile without that patch, that patch also doesn't compile without most the rest of this. Hope it's okay.

Closes #265

@bugadani bugadani force-pushed the embassy branch 2 times, most recently from 994277f to 5b5b8d1 Compare October 18, 2023 09:23
@bjoernQ bjoernQ mentioned this pull request Oct 23, 2023
9 tasks
@bugadani bugadani force-pushed the embassy branch 14 times, most recently from 5542df9 to a37906a Compare October 30, 2023 19:35
@bugadani bugadani force-pushed the embassy branch 6 times, most recently from ec634bb to c8064ca Compare October 31, 2023 16:13
@bugadani bugadani marked this pull request as ready for review October 31, 2023 16:14
@bugadani bugadani marked this pull request as draft October 31, 2023 17:20
@bugadani bugadani force-pushed the embassy branch 3 times, most recently from 8867606 to c02a07e Compare November 1, 2023 22:12
@bugadani bugadani force-pushed the embassy branch 2 times, most recently from 7452d4d to 2654747 Compare November 1, 2023 22:32
Co-Authored-By: Hailey Somerville <hailey@hailey.lol>
@bugadani bugadani marked this pull request as ready for review November 1, 2023 22:41
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit 58374a1 into esp-rs:main Nov 2, 2023
7 checks passed
@bugadani bugadani deleted the embassy branch November 2, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants