Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise API docs #330

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Revise API docs #330

merged 3 commits into from
Nov 3, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Nov 2, 2023

In preparation of #154 this adds some API docs (not the most useful ones but we can improve those in future), hides some types (RxToken/TxToken) and changes other functions and types to pub(crate).

Probably the visibility could be reduced even more but it's a first step without changing too much

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely not an expert in this repo, but docstrings look good to me and makes understanding things a bit easier!

@@ -14,6 +16,7 @@ use crate::wifi::{get_ap_mac, get_sta_mac, WifiDevice, WifiMode};

use core::borrow::BorrowMut;

/// A TCP stack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not just a TCP stack, I think?

@bjoernQ bjoernQ merged commit a20545c into main Nov 3, 2023
14 checks passed
@bjoernQ bjoernQ deleted the revise-docs branch November 3, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants