Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Updated asm! macro to llvm_asm! #13

Merged
merged 36 commits into from
May 31, 2020

Conversation

arjanmels
Copy link
Contributor

No description provided.

@MabezDev
Copy link
Member

Thanks! I'm getting:

error: <inline asm>:57:21: error: invalid operand for instruction
        rur     a3, f64r_hi

I'm guessing this is what you meant by this comment? In which case I'll update the submodule now.

@MabezDev
Copy link
Member

I've updated the submodule in esp-rs/rust#33 . Waiting to build now.

@arjanmels
Copy link
Contributor Author

arjanmels commented May 31, 2020

@MabezDev

Thanks! I'm getting:

error: <inline asm>:57:21: error: invalid operand for instruction
        rur     a3, f64r_hi

I'm guessing this is what you meant by this comment? In which case I'll update the submodule now.

Indeed by that comment and this issue: esp-rs/rust#30.

Take care to use this specific commit espressif/llvm-project@a5a002f. As the commit after that breaks the call ABI as explained in issue: espressif/llvm-project#26.

@MabezDev
Copy link
Member

Perfect! I've updated the fork and this builds!

With this merged, do you think its time to publish the first version on crates.io?
Would you also like me to publish esp32 now that the interrupt stuff is merged?

@MabezDev MabezDev merged commit 7096f9c into esp-rs:master May 31, 2020
@arjanmels
Copy link
Contributor Author

I think there is a solid basis, but I don't know how much work publishing is. There may still crop up additions for the timers (access to the ccompare registers etc.). Same for esp32, there will crop up changes for new peripherals.

@MabezDev
Copy link
Member

Releases for a crate as simple (i.e no weird build processes) as this one its a breeze. It should simplify the dependencies once its released.

@MabezDev
Copy link
Member

This crate is now has a v0.1.0 release! https://crates.io/crates/xtensa-lx6-rt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants