[fix] use new i2c interface for esp32_p4_function_ev_board. (BSP-545) #385
+12
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
|
@100312dog Thank you for the PR! Could you please bump version in https://github.com/espressif/esp-bsp/blob/master/bsp/esp32_p4_function_ev_board/idf_component.yml to 4.0.0? cc @espzav |
tore-espressif
approved these changes
Sep 3, 2024
|
HI @100312dog, thank you for this PR. We are discussing solution for support old and new driver for I2C in BSP. |
espzav
reviewed
Sep 17, 2024
| static TaskHandle_t usb_host_task; // USB Host Library task | ||
| i2c_master_bus_handle_t bsp_i2c_handle = NULL; // Global i2c master bus handler |
There was a problem hiding this comment.
Please, can we add get function like this:
Line 116 in 3284337
and this:
esp-bsp/bsp/esp-box/include/bsp/esp-box.h
Line 241 in 3284337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
BSP uses old i2c interface. when another component such as esp-video uses new i2c interface. They will conflict.