tools: Docker: install build-essential apt package (IDFGH-9402) #10772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, it was not possible to build an application with target `linux` in Docker. For example, building `examples/build_system/cmake/linux_host_app`: ``` docker run -t -e IDF_TARGET="linux" -v "$PWD/examples/build_system/cmake/linux_host_app:/app/linux_host_app" -w "/app/linux_host_app" espressif/idf:v5.0 /bin/bash -c 'git config --global --add safe.directory "*" && idf.py build' ``` results in the following error: ``` CMake Error at /opt/esp/idf/tools/cmake/build.cmake:129 (enable_language): No CMAKE_CXX_COMPILER could be found. ``` This commit adds the `build-essential` package to the list of apt packages to install, which allows the example above to build successfully. Signed-off-by: Nick Miller <nick@golioth.io>
|
|
github-actions
bot
changed the title
|
Thanks for your contribution. |
espressif-bot
added
Status: Selected for Development
|
sha=97c00c7f5be79fa09461cb965647e1a3035aeffd |
espressif-bot
added
Resolution: NA
|
JFYI, we have added this package under the condition that one doesn't set Thank you for letting us know about this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, it was not possible to build an application with target
linuxin Docker.For example, building
examples/build_system/cmake/linux_host_app:results in the following error:
This commit adds the
build-essentialpackage to the list of apt packages to install, which allows the example above to build successfully.