fix: Increase Espressif-IDE heap xms and xmx values to improve performance #1045
Conversation
WalkthroughThe changes reflect a version increment across multiple components of the Espressif IDE, updating from Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant IDE
participant JVM
User->>IDE: Launch IDE
IDE->>JVM: Initialize with new settings
JVM->>IDE: Allocate memory (2048m - 4096m)
IDE->>User: IDE ready with version 3.1.0
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
kolipakakondal
force-pushed
the
IEP-1320
branch
from
d82119c
to
d0c80f4
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- bundles/com.espressif.idf.branding/META-INF/MANIFEST.MF (1 hunks)
- features/com.espressif.idf.feature/feature.xml (1 hunks)
- releng/com.espressif.idf.configuration/pom.xml (1 hunks)
- releng/com.espressif.idf.product/idf.product (2 hunks)
Files skipped from review due to trivial changes (3)
- bundles/com.espressif.idf.branding/META-INF/MANIFEST.MF
- features/com.espressif.idf.feature/feature.xml
- releng/com.espressif.idf.configuration/pom.xml
Additional comments not posted (4)
releng/com.espressif.idf.product/idf.product (4)
4-4: LGTM!The version increment from
3.0.0to3.1.0is approved.
19-19: Verify the memory requirements.Ensure that the target macOS machines have at least 4 GB of RAM to support the increased maximum heap size of
4096m.Run the following script on the target macOS machines to verify the memory:
21-21: Verify the memory requirements.Ensure that the target Windows machines have at least 4 GB of RAM to support the increased maximum heap size of
4096m.Run the following script on the target Windows machines to verify the memory:
17-17: Verify the memory requirements.Ensure that the target Linux machines have at least 4 GB of RAM to support the increased maximum heap size of
4096m.Run the following script on the target Linux machines to verify the memory:
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- releng/com.espressif.idf.product/idf.product (1 hunks)
Additional comments not posted (4)
releng/com.espressif.idf.product/idf.product (4)
17-17: LGTM!The changes to increase the initial and maximum heap sizes for Linux are approved. This should help improve the IDE performance.
19-19: LGTM!The changes to increase the initial and maximum heap sizes for macOS are approved. This should help improve the IDE performance.
21-21: LGTM!The changes to increase the initial and maximum heap sizes for Windows are approved. This should help improve the IDE performance.
Line range hint
4-4: LGTM!The minor version increment to 3.1.0 is approved. It appropriately reflects the performance enhancement changes in this PR.
Description
Increase the initial heap size for Espressif-IDE from 256m to 2048m and the maximum heap size from 2048m to 4096m to improve IDE launch performance. This change also enhances the indexer and parser performance when dealing with a larger number of files.
Fixes # (IEP-1320)
#963
Type of change
How has this been tested?
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit
New Features
com.espressif.idf.brandingbundle to 3.1.0, indicating potential enhancements.com.espressif.idf.featureto 3.1.0, suggesting new functionalities or improvements.espressif-ide-release-versionto 3.1.0, reflecting enhancements or bug fixes in the Espressif IDE.Bug Fixes