Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve the clangd documentation inline with 3.0.0 release #935

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented Apr 12, 2024

Description

Improve the clangd documentation inline with 3.0.0 release

Fixes # (IEP-XXX)

Type of change

  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Documentation
    • Enhanced support for the latest C/C++ standards in Espressif-IDE 3.0.0 and higher.
    • Introduced a new LSP-based C/C++ Editor powered by clangd, replacing the standard CDT Editor/Indexer.

Copy link

coderabbitai bot commented Apr 12, 2024

Walkthrough

The functionality in Espressif-IDE 3.0.0 and higher has been significantly enhanced to support the latest C/C++ standards using the Eclipse CDT-LSP. This update introduces a new LSP-based C/C++ Editor powered by clangd, replacing the standard CDT Editor/Indexer to align with newer language standards and compiler versions for ESP-IDF development.

Changes

File Path Change Summary
docs/clangd_cdt_support.md Enhanced support for latest C/C++ standards via new LSP-based C/C++ Editor in Espressif-IDE 3.0.0+.

Poem

🌟🐇
O hark! A change does come,
Swift like the wind, smart as a drum.
Clangd leads with might,
In IDE's night, a new light.
Code now leaps, as rabbits in spring,
Joy to the devs, updates we bring! 🎉
🐇🌟


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 1922bc2 and 6202fb2.
Files selected for processing (1)
  • docs/clangd_cdt_support.md (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

docs/clangd_cdt_support.md Outdated Show resolved Hide resolved
docs/clangd_cdt_support.md Outdated Show resolved Hide resolved
docs/clangd_cdt_support.md Outdated Show resolved Hide resolved
@kolipakakondal kolipakakondal merged commit 4fd103c into master Apr 12, 2024
2 of 4 checks passed
@kolipakakondal kolipakakondal deleted the clang_lsp_doc_update branch April 12, 2024 16:10
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5


## Prerequisites
1. Install the latest version of [Espressif-IDE](https://github.com/espressif/idf-eclipse-plugin/blob/master/docs/Espressif-IDE.md#downloads)
2. Install the latest version of Eclipse CDT-LSP and it's dependencies using [Update Site](https://dl.espressif.com/dl/idf-eclipse-plugin/updates/latest/)
* You need to have Espressif-IDE 3.0.0 (and higher) to have access to the LSP powered C/C++ editor.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure there are no trailing spaces.

- * You need to have Espressif-IDE 3.0.0 (and higher) to have access to the LSP powered C/C++ editor. 
+ * You need to have Espressif-IDE 3.0.0 (and higher) to have access to the LSP powered C/C++ editor.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
* You need to have Espressif-IDE 3.0.0 (and higher) to have access to the LSP powered C/C++ editor.
* You need to have Espressif-IDE 3.0.0 (and higher) to have access to the LSP powered C/C++ editor.

1. Install the latest version of [Espressif-IDE](https://github.com/espressif/idf-eclipse-plugin/blob/master/docs/Espressif-IDE.md#downloads)
2. Install the latest version of Eclipse CDT-LSP and it's dependencies using [Update Site](https://dl.espressif.com/dl/idf-eclipse-plugin/updates/latest/)
* You need to have Espressif-IDE 3.0.0 (and higher) to have access to the LSP powered C/C++ editor.
* If you are updating Eclipse CDT or Espressif-IDE via the update site, you need to select the ESP-IDF Eclipse Plugin and its dependencies, as shown below:

![](images/clangd/cdtlsp_updatesite.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add alternate text to the image for accessibility.

- 	![](images/clangd/cdtlsp_updatesite.png)
+ 	![Update site configuration for Espressif-IDE](images/clangd/cdtlsp_updatesite.png)

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
![](images/clangd/cdtlsp_updatesite.png)
![Update site configuration for Espressif-IDE](images/clangd/cdtlsp_updatesite.png)

Remove: [-fno-tree-switch-conversion, -fstrict-volatile-bitfields]
CompilationDatabase: build
Remove: [-m*, -f*]
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure there are no trailing spaces.

-  Remove: [-m*, -f*]
+  Remove: [-m*, -f*] 

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
```

Comment on lines +50 to +51


Copy link