Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bundled JRE 17 with Espressif-IDE #942

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

sigmaaa
Copy link
Collaborator

@sigmaaa sigmaaa commented May 6, 2024

Description

Bundled JRE 17 with Espressif-IDE

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Download Espressif-IDE from this PR on different platforms and verify that espressif-ide.ini contains lines such as
    "-vm
    plugins/org.eclipse.justj.openjdk.hotspot.jre.full.win32.x86_64_17.0.11.v20240426-1830/jre/bin"
  • Espressif-IDE should run without installing Java

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • New Features

    • Enhanced compatibility by updating Java SE version from 11 to 17 for Linux, macOS, and Windows platforms.
    • Added support for OpenJDK Hotspot JRE.
  • Refactor

    • Updated target platform configurations across various modules to improve performance and compatibility with different operating systems.

Copy link

coderabbitai bot commented May 6, 2024

Walkthrough

The recent updates focus on enhancing Java support across various modules and platforms within the project. Key changes include upgrading Java SE versions from 11 to 17 for Linux, macOS, and Windows, and integrating the Eclipse JustJ OpenJDK Hotspot JRE Full feature. These adjustments ensure compatibility and performance improvements across different operating systems and development environments.

Changes

File Path Change Summary
bundles/pom.xml Added plugin configuration for target platform with specific execution environments.
releng/.../configuration/pom.xml Specified Java execution environment as OpenJDK Hotspot JRE Full-17.
releng/.../idf.product/idf.product Updated Java SE version from 11 to 17 for Linux and macOS; added OpenJDK Hotspot JRE feature.
releng/.../idf.product/pom.xml Added <executionEnvironment> tag with OpenJDK Hotspot JRE Full-17.
releng/.../idf.target/com.espressif.idf.target.target Added new Eclipse plugin installation location.

🐰✨
Oh hark! A change does come,
With Java's beat like a drum.
From eleven to seventeen,
Across the screens, now seen.
Hop, skip, a leap so bright,
CodeRabbit cheers with delight! 🌟
🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c270b54 and 1e32282.
Files selected for processing (5)
  • bundles/pom.xml (1 hunks)
  • releng/com.espressif.idf.configuration/pom.xml (1 hunks)
  • releng/com.espressif.idf.product/idf.product (2 hunks)
  • releng/com.espressif.idf.product/pom.xml (2 hunks)
  • releng/com.espressif.idf.target/com.espressif.idf.target.target (1 hunks)
Files skipped from review due to trivial changes (3)
  • releng/com.espressif.idf.configuration/pom.xml
  • releng/com.espressif.idf.product/idf.product
  • releng/com.espressif.idf.target/com.espressif.idf.target.target
Additional comments not posted (2)
bundles/pom.xml (1)

43-72: Ensure the new plugin configuration aligns with project requirements for Java 17.

The addition of the <plugin> configuration for org.eclipse.tycho:target-platform-configuration with the execution environment set to org.eclipse.justj.openjdk.hotspot.jre.full-17 is crucial for ensuring that the IDE is compatible with Java 17 across different operating systems. This change aligns with the PR's objective to enhance IDE functionality and compatibility with newer Java features.

releng/com.espressif.idf.product/pom.xml (1)

Line range hint 117-144: Ensure the new execution environment configuration aligns with project requirements for Java 17.

The addition of the <executionEnvironment> tag specifying org.eclipse.justj.openjdk.hotspot.jre.full-17 in the target-platform-configuration plugin ensures that the Espressif IDE will utilize Java 17, enhancing its performance and compatibility across different platforms. This change is consistent with the updates in other configuration files and supports the PR's goals.

@AndriiFilippov
Copy link
Collaborator

@sigmaaa hi !

Tested under:
OS - Windows 10 / MacOS / Linux
ESP-IDF: v5.2.1

Able to run Eclipse -> use Espressif Plugin -> create / build / flash / monitor project -> without Java installed. ✔️

LGTM 👍

@kolipakakondal kolipakakondal merged commit de93cb3 into master May 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants