fixed unit tests

[alirana01]

Description

Unit tests fixed for windows due to native windows api code

Fixes # (IEP-1234)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Checklist

• PR Self Reviewed
• Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

• Tests
  • Added Windows-specific tests using @EnabledOnOs(OS.WINDOWS) annotations to ensure compatibility and functionality on Windows operating systems.

[coderabbitai]

Walkthrough

The recent update to the ExecutableFinderTest.java file enhances the testing framework by incorporating Windows-specific test conditions. This was achieved by importing necessary annotations from org.junit.jupiter.api.condition and applying them to relevant test methods. This ensures that certain tests are executed only on Windows operating systems, improving the accuracy and relevance of the test suite.

Changes

File Path	Change Summary
tests/com.espressif.idf.core.test/src/com/espressif/idf/core/unittest/ExecutableFinderTest.java	Added imports for EnabledOnOs and OS from org.junit.jupiter.api.condition. Annotated test methods with @EnabledOnOs(OS.WINDOWS) for Windows-specific testing.

🐇 In the realm of code so grand,
Tests now heed the system's land.
Windows calls, they now obey,
Ensuring all in proper array.
With annotations set in place,
Our tests now run with greater grace.
🖥️✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6356f40 and ab3018f.

Files selected for processing (1)

• tests/com.espressif.idf.core.test/src/com/espressif/idf/core/unittest/ExecutableFinderTest.java (4 hunks)

Additional comments not posted (9)

tests/com.espressif.idf.core.test/src/com/espressif/idf/core/unittest/ExecutableFinderTest.java (9)

16-17: Imports correctly added for Windows-specific testing.

---

143-143: Correctly restricts the test to run only on Windows.

---

151-151: Properly tests for non-existent executables on Windows.

---

159-159: Effectively tests the handling of null inputs on Windows.

---

167-167: Tests behavior with an empty PATH environment, which is a critical edge case.

---

176-176: Tests behavior when executable extensions are not defined in the environment.

---

185-185: Ensures non-executable files are not mistakenly identified as executables.

---

193-193: Validates the behavior for non-existent non-executable files.

---

201-201: Tests the resilience of the system against incorrect executable extensions.

[sigmaaa]

LGTM