embed: fix revision-based compaction with default value

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
etcd-io · Feb 21, 2018 · 6ab320d · 6ab320d
1 parent 74279c7
commit 6ab320d
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/embed/etcd.go b/embed/etcd.go
@@ -144,8 +144,14 @@ func StartEtcd(inCfg *Config) (e *Etcd, err error) {
 	}
 	h, err = strconv.Atoi(cfg.AutoCompactionRetention)
 	if err == nil {
-		autoCompactionRetention = time.Duration(int64(h)) * time.Hour
+		switch cfg.AutoCompactionMode {
+		case CompactorModeRevision:
+			autoCompactionRetention = time.Duration(int64(h))
+		case CompactorModePeriodic:
+			autoCompactionRetention = time.Duration(int64(h)) * time.Hour
+		}
 	} else {
+		// periodic compaction
 		autoCompactionRetention, err = time.ParseDuration(cfg.AutoCompactionRetention)
 		if err != nil {
 			return nil, fmt.Errorf("error parsing AutoCompactionRetention: %v", err)