Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: mark AuthStatus as no side effect request #11610

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Feb 11, 2020

This is a follow up change of #11536
The newly added AuthStatus() RPC doesn't have side effect against the state machine so we should mark it as no side effect request for avoiding replay overhead.

cc @tarcinil

@tarcinil
Copy link
Contributor

@codecov-io
Copy link

Codecov Report

Merging #11610 into master will decrease coverage by 0.81%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11610      +/-   ##
==========================================
- Coverage   65.22%    64.4%   -0.82%     
==========================================
  Files         403      403              
  Lines       37651    37651              
==========================================
- Hits        24558    24251     -307     
- Misses      11499    11805     +306     
- Partials     1594     1595       +1
Impacted Files Coverage Δ
etcdserver/apply.go 77.04% <100%> (ø) ⬆️
client/client.go 44.11% <0%> (-39.87%) ⬇️
pkg/transport/timeout_conn.go 60% <0%> (-20%) ⬇️
auth/store.go 59.94% <0%> (-18.12%) ⬇️
etcdserver/api/v3rpc/util.go 51.61% <0%> (-16.13%) ⬇️
auth/simple_token.go 76.47% <0%> (-12.61%) ⬇️
clientv3/naming/grpc.go 63.15% <0%> (-12.29%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
etcdserver/api/v3rpc/lease.go 70.45% <0%> (-4.55%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c90eb...fda8d38. Read the comment docs.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spzala
Copy link
Member

spzala commented Feb 11, 2020

Thanks @mitake Straightforward changes so merging!

@spzala spzala merged commit a0bb739 into etcd-io:master Feb 11, 2020
@mitake mitake deleted the authstatus branch February 12, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants