grpcproxy: make grpc keep alive related options configurable #11711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Apr 4, 2020
etcdmain/grpc_proxy.go
Outdated
| PermitWithoutStream: false, | ||
| })) | ||
| } | ||
| if grpcKeepAliveInterval > time.Duration(0) && |
There was a problem hiding this comment.
we probably should return an error if only of the two points are set.
There was a problem hiding this comment.
I go through the GRPC's code again and found that these two options are independent of each other, if one of them are not set, the grpc server will fill it with the default values, see here. So I changed if grpcKeepAliveInterval > time.Duration(0) && grpcKeepAliveTimeout > time.Duration(0) to if grpcKeepAliveInterval > time.Duration(0) || grpcKeepAliveTimeout > time.Duration(0).
By the way, I think the main etcd code should also make this adjustment.
Currently grpc-proxy doesn't config keep alive related options, so it will use the default values provided by the underlay gprc library. If clients uses a keep alive ping interval smaller than server's default minTime, connections between server and clients will be closed and reopened frequently.
|
LGTM. Can you add this to the change log? |
mlmhl
added a commit
to mlmhl/etcd
that referenced
this pull request
Apr 16, 2020
mlmhl
added a commit
to mlmhl/etcd
that referenced
this pull request
Apr 16, 2020
mlmhl
added a commit
to mlmhl/etcd
that referenced
this pull request
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently grpc-proxy doesn't config keep alive related options, so it will use the default values provided by the underlay gprc library. If clients uses a keep alive ping interval smaller than server's default minTime, connections between server and clients will be closed and reopened frequently.
For example, kubernetes's apiserver uses a 30s keep alive ping interval which is a typical value used by many clients, grpc-proxy uses the default minTime 5m, provided by grpc. As 5m is much bigger than 30s, so the connections will be closed and reopened frequently due to too_many_pings error.