etcdserver, et al: add --unsafe-no-fsync flag #11946
Conversation
This makes it possible to run an etcd node for testing and development without placing lots of load on the file system. Fixes etcd-io#11930. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
crawshaw
force-pushed
the
crawshaw/nofsync
branch
from
47c9790
to
66cb045
Compare
Codecov Report
@@ Coverage Diff @@
## master #11946 +/- ##
==========================================
- Coverage 66.40% 66.23% -0.18%
==========================================
Files 403 403
Lines 37258 37273 +15
==========================================
- Hits 24742 24686 -56
- Misses 10992 11049 +57
- Partials 1524 1538 +14
Continue to review full report at Codecov.
|
|
Also add to CHANGELOG for 3.5 and Documentation/op-guide/configuration.md? lgtm to me otherwise. |
|
@crawshaw Can we create a separate PR to add this change in CHANGELOG? Thanks! |
|
Can we please backport this? |
|
While we usually don't backport features to release branches, I think we should consider making an exception for this given that (a) it is intended to be used in test and (b) it has a lot of promise to speed up tests significantly. If this makes a noticeable dent in k8s test times, and I think it might, it could really help the project. I've opened #11977 for the backport. Please discuss there. |
|
Do we want this flag included in the Lines 26 to 31 in 49f91d6 |
…-release-3.4 Automated cherry pick of #11946
|
@jpbetz Oh, yes. we forgot. Can we update help page? thx! |
In [1], disabling fsync for development deployments of etcd is suggested. [1]: etcd-io/etcd#11946 Signed-off-by: Maël Valais <mael@vls.dev> Co-authored-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Using --unsafe-no-fsync is OK for development deployments of etcd [1]. etcd relies on fsync for its consensus protocol. [1]: etcd-io/etcd#11946 [2]: https://etcd.io/docs/v3.5/tuning/#disk [3]: https://etcd.io/docs/v3.5/faq/ Signed-off-by: Maël Valais <mael@vls.dev> Co-authored-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Using --unsafe-no-fsync is OK for development deployments of etcd [1]. etcd relies on fsync for its consensus protocol. [1]: etcd-io/etcd#11946 [2]: https://etcd.io/docs/v3.5/tuning/#disk [3]: https://etcd.io/docs/v3.5/faq/ Signed-off-by: Maël Valais <mael@vls.dev> Co-authored-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
This makes it possible to run an etcd node for testing and development
without placing lots of load on the file system.
Fixes #11930