Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow commandline overrides 3.4 #12269

Closed
wants to merge 2 commits into from
Closed

Allow commandline overrides 3.4 #12269

wants to merge 2 commits into from

Commits on Sep 3, 2020

  1. Revert "pkg/flags: fatal on conflicting environment variable" 

    This reverts commit 748ab8c.

This is an unnecessary breaking change from upgrading from 3.3, also
having both environmental variables and being able to override them
via commandline is a highly desired feature.
    @dbavatar
    dbavatar committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    2d59281 View commit details
    Browse the repository at this point in the history

  2. pkg/flags: log info message when overriding environment 

    It should not be a warning: the user explicitly requested an override.
    @dbavatar
    dbavatar committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    cb907dc View commit details
    Browse the repository at this point in the history