Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup grpc client/v3/naming API #12675

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Feb 8, 2021

This PR:

  • Removes legacy grpc_resolver code.
  • Switches grpc_proxy to the new code.

It's part of #12652 effort.

@ptabor ptabor marked this pull request as draft February 8, 2021 22:20
@ptabor ptabor force-pushed the 20210209-grpc-remove-legacy-resolver branch from 5ca5a44 to 7938563 Compare February 8, 2021 22:58
@ptabor ptabor marked this pull request as ready for review February 8, 2021 23:04
@@ -79,38 +82,36 @@ func NewClusterProxy(lg *zap.Logger, c *clientv3.Client, advaddr string, prefix
return cp, donec
}

func (cp *clusterProxy) resolve(prefix string) {
func (cp *clusterProxy) establishEndpointWatch(em endpoints.Manager, prefix string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, establishEndpointWatch is a method and we create em endpoints.Manager only once, right? Think em endpoints.Manager is better defined as a field inside cp *clusterProxy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. PTAL.

@ptabor ptabor force-pushed the 20210209-grpc-remove-legacy-resolver branch from 7938563 to 858bafe Compare February 9, 2021 10:27
Update grpcproxy to use the new abstractions.
@ptabor ptabor force-pushed the 20210209-grpc-remove-legacy-resolver branch from 858bafe to a836a80 Compare February 9, 2021 10:56
@ptabor ptabor requested a review from gyuho February 10, 2021 11:16
@ptabor ptabor merged commit 77e6df2 into etcd-io:master Feb 11, 2021
@ptabor ptabor deleted the 20210209-grpc-remove-legacy-resolver branch February 11, 2021 08:31
@fuweid fuweid mentioned this pull request Oct 13, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants