learner support snapshot RPC #12890
Merged
learner support snapshot RPC #12890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12890 +/- ##
==========================================
- Coverage 72.34% 67.94% -4.40%
==========================================
Files 428 405 -23
Lines 33888 33116 -772
==========================================
- Hits 24515 22502 -2013
- Misses 7413 8697 +1284
+ Partials 1960 1917 -43
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Also add this change into ChangeLog? |
|
@xiang90 ok, updated. thanks. |
tangcong
force-pushed
the
learner-snapshot
branch
from
320f0a4
to
2b0012c
Compare
|
LGTM /cc @jingyih Can you also take a look? |
tangcong
added a commit
to tangcong/etcd
that referenced
this pull request
May 15, 2021
* learner support snapshot RPC * CHANGELOG: update for 12890
YaoC
pushed a commit
to YaoC/etcd
that referenced
this pull request
Nov 22, 2023
Signed-off-by: YaoC <chengyao09@hotmail.com>
ahrtr
added a commit
that referenced
this pull request
Nov 23, 2023
[3.4] backport #12890 learner support snapshot RPC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce the performance impact on voting member nodes (especially when the node's disk I/O is poor), some users and we want to perform regular snapshot backup on the learner node.