Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant fsync for WAL #13048

Closed
wants to merge 1 commit into from

Conversation

mrkm4ntr
Copy link
Contributor

Because the hard state is already on disk after invocation of wal.Save.

etcd/server/wal/wal.go

Lines 937 to 944 in 71934ff

if curOff < SegmentSizeBytes {
if mustSync {
return w.sync()
}
return nil
}
return w.cut()

if err := w.sync(); err != nil {

I've already checked with steps to reproduce of #10219 and there is no problem.

Because the hard state is already on disk after invocation of wal.Save
@ptabor
Copy link
Contributor

ptabor commented Jun 2, 2021

Can you, please, sync with @brk0v whether the fix is really unneeded. I have limited trust to failpoints based tests to be (still) working.

@mrkm4ntr
Copy link
Contributor Author

mrkm4ntr commented Jun 3, 2021

@brk0v, @jpbetz Could you take a look at this?

@stale
Copy link

stale bot commented Sep 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 2, 2021
@stale stale bot closed this Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants