Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] etcdserver: intentionally set the memberID as 0 in corruption alarm #14852

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Nov 25, 2022

@ahrtr ahrtr changed the title etcdserver: intentionally set the memberID as 0 in corruption alarm [3.5] etcdserver: intentionally set the memberID as 0 in corruption alarm Nov 25, 2022
@ahrtr ahrtr force-pushed the remove_memberid_alarm_3.5_20221125 branch 3 times, most recently from a9d7873 to 47ff26f Compare November 25, 2022 08:19
Signed-off-by: Benjamin Wang <wachao@vmware.com>
@ahrtr
Copy link
Member Author

ahrtr commented Nov 25, 2022

cc @serathius

Copy link
Contributor

@ptabor ptabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG entry. It's a behavioural change.

@ahrtr ahrtr merged commit 5454ca6 into etcd-io:release-3.5 Nov 25, 2022
@ahrtr
Copy link
Member Author

ahrtr commented Nov 25, 2022

Please add a CHANGELOG entry. It's a behavioural change.

ALready added in another PR. Actually the memberID had always been 0 due to an issue #14272. So there is no behavior change:)

tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Jul 26, 2023
…_20221125

[3.5] etcdserver: intentionally set the memberID as 0 in corruption alarm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants