Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Backport: netutil: consistently format ipv6 addresses #15188

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

Kidsan
Copy link
Contributor

@Kidsan Kidsan commented Jan 26, 2023

This is a backport of #15153
This formats ipv6 addresses to ensure they can be compared safely

Signed-off-by: kidsan 8798449+Kidsan@users.noreply.github.com

This formats ipv6 addresses to ensure they can be compared safely

Signed-off-by: kidsan <8798449+Kidsan@users.noreply.github.com>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr
Copy link
Member

ahrtr commented Jan 26, 2023

@Kidsan
Copy link
Contributor Author

Kidsan commented Jan 26, 2023

Please add a changelog item in https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.4.md

changelog PR: #15190

@ahrtr ahrtr merged commit c5347cb into etcd-io:release-3.4 Jan 26, 2023
@Kidsan Kidsan deleted the fix/ipv6-comparisons-release-3.4 branch January 27, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants