server/storage/schema: prefer equal to compare for equality comparisons #15915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Batschelet <sbatschelet@gmail.com>
jmhbnz
approved these changes
May 17, 2023
There was a problem hiding this comment.
LGTM - Though is there any context on how much of a difference this will make for etcd? The linked benchmarks are in nanoseconds per operation, I'm wondering if there is expected to be a more pronounced impact for etcd?
If not it would probably not be a priority to review any other code using bytes.Compare though at first glance this looks like it might be the only instance where we do a straight ==.
FYI. Slice, map, and function types are not comparable in golang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks show
bytes.Equalis much faster thanbytes.Compare[1] for equality comparisons and preferred per the example in docs[2].[1] https://www.sobyte.net/post/2022-01/go-bytes-compare-equal/
[2] https://pkg.go.dev/bytes#Compare