Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Upgrade gRPC-go to 1.58.3 #16790

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

chaochn47
Copy link
Member

@chaochn47 chaochn47 commented Oct 17, 2023

The last step with gRPC update behavior changes auditing to resolve CVE #16740 in 3.5

This PR backports #14922, #16338, #16587, #16630, #16636 and #16739 to release-3.5.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

The last step with gRPC update behavior changes auditing to resolve CVE etcd-io#16740 in 3.5

This PR backports etcd-io#14922, etcd-io#16338, etcd-io#16587, etcd-io#16630, etcd-io#16636 and etcd-io#16739 to release-3.5.

Signed-off-by: Chao Chen <chaochn@amazon.com>
@chaochn47
Copy link
Member Author

chaochn47 commented Oct 17, 2023

@chaochn47 chaochn47 marked this pull request as ready for review October 17, 2023 18:39
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for all the hard work getting this across the line for 3.5.10 @chaochn47.

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjungblu
Copy link
Contributor

/lgtm

Thanks @chaochn47 :)

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx @chaochn47

@ahrtr ahrtr changed the title 3.5: upgrade gRPC-go to 1.58.3 [3.5] Upgrade gRPC-go to 1.58.3 Oct 18, 2023
@chaochn47
Copy link
Member Author

Could you please take a look @serathius? Looks like this is the last remaining item of #16733.

@ahrtr
Copy link
Member

ahrtr commented Oct 19, 2023

merging...thx @chaochn47 again!

@ahrtr ahrtr merged commit 3521aaa into etcd-io:release-3.5 Oct 19, 2023
12 checks passed
dusk125 pushed a commit to dusk125/etcd that referenced this pull request Oct 19, 2023
@chaochn47 chaochn47 deleted the 3.5-grpc-update branch October 20, 2023 05:09
dusk125 pushed a commit to dusk125/etcd that referenced this pull request Oct 20, 2023
@ahrtr ahrtr mentioned this pull request Oct 23, 2023
dusk125 pushed a commit to dusk125/etcd that referenced this pull request Oct 30, 2023
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/etcd that referenced this pull request Nov 6, 2023
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/etcd that referenced this pull request Nov 6, 2023
chaochn47 added a commit to chaochn47/etcd that referenced this pull request Nov 22, 2023
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47 added a commit to chaochn47/etcd that referenced this pull request Nov 22, 2023
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47 added a commit to chaochn47/etcd that referenced this pull request Nov 22, 2023
Signed-off-by: Chao Chen <chaochn@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants