Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Add missing experimental-enable-lease-checkpoint-persist flag in etcd help #17189

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

ishan16696
Copy link
Contributor

I was working on this issue: #17132 when I found that flag --experimental-enable-lease-checkpoint-persist is missing from etcd --help in etcd version 3.4.x
Please check this: #17132 (comment)

Signed-off-by: ishan16696 <ishan.tyagi@sap.com>
@k8s-ci-robot
Copy link

Hi @ishan16696. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green - thanks @ishan16696

/ok-to-test

@jmhbnz
Copy link
Member

jmhbnz commented Jan 2, 2024

/retitle [3.4] Add missing experimental-enable-lease-checkpoint-persist flag in etcd help

@k8s-ci-robot k8s-ci-robot changed the title Added a missing flag in etcd help. [3.4] Add missing experimental-enable-lease-checkpoint-persist flag in etcd help Jan 2, 2024
@serathius serathius merged commit 2664430 into etcd-io:release-3.4 Jan 3, 2024
12 checks passed
@ishan16696 ishan16696 deleted the add/missingFlag branch January 3, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants