Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Fix ts with no trailing zeros #18288

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #18108

/assign jmhbnz

Signed-off-by: Chao Chen <chaochn@amazon.com>
@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmhbnz
Copy link
Member

jmhbnz commented Jul 6, 2024

/ok-to-test

@jmhbnz
Copy link
Member

jmhbnz commented Jul 6, 2024

Proposing this backport for release-3.5 for inclusion in our upcoming v3.5.15.

cc @ahrtr, @serathius, @ivanvc

@jmhbnz jmhbnz requested review from ivanvc, serathius and ahrtr July 6, 2024 10:57
@jmhbnz jmhbnz changed the title [release-3.5] fix ts with no trailing zeros [3.5] Fix ts with no trailing zeros Jul 6, 2024
@jmhbnz jmhbnz mentioned this pull request Jul 6, 2024
4 tasks
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks, @jmhbnz

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, ivanvc, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 301b124 into etcd-io:release-3.5 Jul 9, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants