Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG Differentiate the warning message for rejected client and peer connections for release-3.5 #18320

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jul 14, 2024

…ted client and peer connections

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.97%. Comparing base (f0612bb) to head (96d280a).

Current head 96d280a differs from pull request most recent head 2f9225a

Please upload reports for the commit 2f9225a to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 17 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18320      +/-   ##
==========================================
+ Coverage   68.87%   68.97%   +0.10%     
==========================================
  Files         417      417              
  Lines       35333    35333              
==========================================
+ Hits        24334    24370      +36     
+ Misses       9577     9550      -27     
+ Partials     1422     1413       -9     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0612bb...2f9225a. Read the comment docs.

@k8s-ci-robot
Copy link

@ahrtr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-robustness-amd64 2f9225a link false /test pull-etcd-robustness-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz
Copy link
Member

jmhbnz commented Jul 14, 2024

/retest

@jmhbnz
Copy link
Member

jmhbnz commented Jul 14, 2024

/retitle CHANGELOG Differentiate the warning message for rejected client and peer connections for release-3.5

@k8s-ci-robot k8s-ci-robot changed the title Update 3.5 changelog to cover the separated warning message for rejecchangelog_log_20240714 CHANGELOG Differentiate the warning message for rejected client and peer connections for release-3.5 Jul 14, 2024
@ahrtr ahrtr merged commit 45a81f9 into etcd-io:main Jul 14, 2024
42 of 43 checks passed
@ahrtr ahrtr deleted the changelog_log_20240714 branch July 14, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants