Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: update changes for issue 18089 #18482

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Aug 21, 2024

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (4dab785) to head (3f2d4dc).
Report is 2 commits behind head on main.

Current head 3f2d4dc differs from pull request most recent head 8db31b6

Please upload reports for the commit 8db31b6 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 12 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18482      +/-   ##
==========================================
+ Coverage   68.81%   68.84%   +0.03%     
==========================================
  Files         420      420              
  Lines       35490    35490              
==========================================
+ Hits        24421    24432      +11     
+ Misses       9640     9635       -5     
+ Partials     1429     1423       -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dab785...8db31b6. Read the comment docs.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fuweid, etcd server entry lgtm. Question below on adding test changes, I defer to Marek & Benjamin on this.

CHANGELOG/CHANGELOG-3.4.md Outdated Show resolved Hide resolved
@@ -8,13 +8,18 @@ Previous change logs can be found at [CHANGELOG-3.3](https://github.com/etcd-io/

### etcd server
- Fix [performance regression issue caused by the `ensureLeadership` in lease renew](https://github.com/etcd-io/etcd/pull/18440).
- [keep tombstone if revision == compactAtRev](https://github.com/etcd-io/etcd/pull/18475)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [keep tombstone if revision == compactAtRev](https://github.com/etcd-io/etcd/pull/18475)
- [Keep the tombstone during compaction if it happens to be the compaction revision](https://github.com/etcd-io/etcd/pull/18475).

@@ -8,10 +8,17 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/

### etcd server
- Fix [performance regression issue caused by the `ensureLeadership` in lease renew](https://github.com/etcd-io/etcd/pull/18439).
- [keep tombstone if revision == compactAtRev](https://github.com/etcd-io/etcd/pull/18474)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@ahrtr
Copy link
Member

ahrtr commented Aug 22, 2024

Link to #18089

Signed-off-by: Wei Fu <fuweid89@gmail.com>
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 5485c71 into etcd-io:main Aug 22, 2024
46 checks passed
@fuweid fuweid deleted the update-changelog branch August 22, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants