Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrency: retry snapshot serializable stm if writes since first header rev #8439

Merged
merged 3 commits into from
Aug 23, 2017

Conversation

heyitsanthony
Copy link
Contributor

Was checking the rset key mod rev, which does not work.

defer clus.Terminate(t)

cli := clus.Client(0)
// key with different revision from keys updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean key with different revision from keys updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the create/mod rev is always earlier than the keys set via stm

@heyitsanthony heyitsanthony force-pushed the stm-serialized-snapshot branch 2 times, most recently from b962863 to b206afc Compare August 23, 2017 02:36
Anthony Romano added 3 commits August 22, 2017 19:39
…ader rev

Was checking the rset key mod rev, which does not work.
Worked by coincidence; the txn would always retry and there
was a 1/10 chance it would pass by selecting the same to/from keys.
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@heyitsanthony heyitsanthony merged commit 8e7a0de into etcd-io:master Aug 23, 2017
@heyitsanthony heyitsanthony deleted the stm-serialized-snapshot branch August 23, 2017 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants