Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3: prevent wrong URLs to cluster APIs #9174

Merged
merged 3 commits into from
Jan 22, 2018
Merged

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jan 19, 2018

Prevent #9173 in client-side.

@codecov-io
Copy link

Codecov Report

Merging #9174 into master will decrease coverage by 0.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9174      +/-   ##
==========================================
- Coverage   76.21%   75.78%   -0.43%     
==========================================
  Files         359      359              
  Lines       30041    30045       +4     
==========================================
- Hits        22896    22771     -125     
- Misses       5567     5670     +103     
- Partials     1578     1604      +26
Impacted Files Coverage Δ
clientv3/cluster.go 91.89% <100%> (+0.98%) ⬆️
client/keys.go 64.32% <0%> (-27.14%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-25%) ⬇️
pkg/fileutil/purge.go 73.68% <0%> (-7.9%) ⬇️
pkg/adt/interval_tree.go 84.38% <0%> (-6.61%) ⬇️
etcdserver/api/v3rpc/lease.go 81.08% <0%> (-5.41%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
proxy/grpcproxy/watch.go 90.06% <0%> (-3.11%) ⬇️
etcdserver/api/v3rpc/watch.go 84.12% <0%> (-3.01%) ⬇️
etcdserver/api/v3election/election.go 64.7% <0%> (-2.95%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e6417b...a4e2a08. Read the comment docs.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@gyuho
Copy link
Contributor Author

gyuho commented Jan 22, 2018

@fanminshi All fixed.

@fanminshi
Copy link
Member

lgtm

@gyuho gyuho merged commit b590d52 into etcd-io:master Jan 22, 2018
@gyuho gyuho deleted the url-error branch January 22, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants