Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvcc: watcherGroup chooseAll panic (skip proxy tests for now) #9765

Merged
merged 2 commits into from
May 23, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 23, 2018

This is the new test #9745 that I've added to simulate #9281 with real-world use case.

Only fails in proxy tests...

https://jenkins-etcd.prod.coreos.systems/job/etcd-proxy/4824/console

=== RUN   TestV3WatchRestoreSnapshotUnsync
panic: watcher current revision should not exceed current revision

goroutine 170309 [running]:
github.com/coreos/etcd/mvcc.(*watcherGroup).chooseAll(0xc4242791c0, 0x10, 0xffffffffffffffff, 0x1)
	/go/src/github.com/coreos/etcd/mvcc/watcher_group.go:241 +0x273
github.com/coreos/etcd/mvcc.(*watcherGroup).choose(0xc4242791c0, 0x200, 0x10, 0xffffffffffffffff, 0xc426479858, 0xc426479858)
	/go/src/github.com/coreos/etcd/mvcc/watcher_group.go:224 +0x289
github.com/coreos/etcd/mvcc.(*watchableStore).syncWatchers(0xc424279180, 0x0)
	/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:340 +0x237
github.com/coreos/etcd/mvcc.(*watchableStore).syncWatchersLoop(0xc424279180)
	/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:214 +0x280
created by github.com/coreos/etcd/mvcc.newWatchableStore
	/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:90 +0x477
FAIL	github.com/coreos/etcd/integration	526.777s

Will investigate in a separate PR.

gyuho added 2 commits May 23, 2018 15:35
When run with "-tags cluster_proxy", panic.
Need investigate more.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@gyuho gyuho merged commit b4f84f0 into etcd-io:master May 23, 2018
@gyuho gyuho deleted the watch-restore branch May 23, 2018 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant