Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG: Add 3.4 changelog entry for snapshot file permissions change #9991

Merged
merged 1 commit into from
Aug 10, 2018
Merged

CHANGELOG: Add 3.4 changelog entry for snapshot file permissions change #9991

merged 1 commit into from
Aug 10, 2018

Conversation

dlipovetsky
Copy link
Contributor

No description provided.

@dlipovetsky
Copy link
Contributor Author

dlipovetsky commented Aug 9, 2018 •
edited
Loading

This is the release note for #9977. I'm a little unsure as to where to put the note. Please let me know if I should move this note--or add another note--to a different section. Thanks!

hexfusion
hexfusion reviewed Aug 9, 2018
View reviewed changes
Copy link
Contributor

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this could be a breaking change for Linux workflows assuming file perms, lgtm.

defer to @gyuho

@hexfusion
Copy link
Contributor

#9977

@gyuho
Copy link
Contributor

gyuho commented Aug 9, 2018

Agree with @hexfusion. Let's also mention this in breaking changes section, to be safe.

@hexfusion
Copy link
Contributor

hexfusion commented Aug 9, 2018 •
edited
Loading

@dlipovetsky, just also add this note to the client-v3 section of the doc rebase and we are good. Thanks!

https://github.com/coreos/etcd/blob/master/CHANGELOG-3.4.md#client-v3

@dlipovetsky dlipovetsky force-pushed the snapshot-file-permission-release-note branch from 254391d to f52a990 Compare August 10, 2018 20:37
@dlipovetsky
Copy link
Contributor Author

@hexfusion and @gyuho Thanks for reviewing.

I put the note in both the "breaking changes" and "client v3" sections.

@gyuho gyuho merged commit 59e084d into etcd-io:master Aug 10, 2018
@dlipovetsky dlipovetsky deleted the snapshot-file-permission-release-note branch August 11, 2018 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexfusion hexfusion hexfusion left review comments

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlipovetsky @hexfusion @gyuho