Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment Lab Explore gallery by experimental phase #369

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

tkaragianes
Copy link
Contributor

@tkaragianes tkaragianes commented Nov 17, 2023

Summary

This makes the lab page easier to understand, highlighting the labs that are currently accepting submissions and giving context for other labs based on their phase in the experimental pipeline.

Before:
Screenshot 2023-11-17 at 13-33-41 Eterna

After:
Screenshot 2023-11-17 at 13-51-10 Eterna

Implementation Notes

The LabExplore page now uses a computed property to segment the labs by experimental phase, and displays the lab cards in collapsible sections. Any lab without an experimental phase or that is older than 2 years (just a suggested timescale, can easily adjust) is placed into an "Archived" section, as some old labs are paused at various stages of the experimental pipeline.

Testing

Visually verified on local environment.

Related Issues

Closes #94.

@luxaritas
Copy link
Member

Potential concern: We pull back one page of labs at a time, ordered by status then date. What happens when the first page is all in one category but the user goes to look at a different category? Additionally, how does that play with the infinite-scroll logic?

@DigitalEmbrace
Copy link
Contributor

Will all successfully completed labs appear under Results Posted regardless of date? I like the layout as long as all labs with results are grouped under that tab and only suspended labs are grouped under Archived. I assume labs will continue to be organized by date within each tab. Two-year timescale is good for archive status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lab page should default to active labs only
3 participants