Support purely single threaded execution #370
Merged
+52
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
force-pushed
the
aj/singlethreaded
branch
from
8f87821
to
5d4ded8
Compare
protolambda
reviewed
Aug 26, 2024
|
@protolambda Good call-out - updated fork.yaml. |
protolambda
approved these changes
Aug 27, 2024
karlb
pushed a commit
to celo-org/op-geth
that referenced
this pull request
Sep 10, 2024
When only a single CPU is available: * Avoid creating threads in StateDB.IntermediateRoot * Force single threaded hashing
karlb
pushed a commit
to celo-org/op-geth
that referenced
this pull request
Sep 16, 2024
When only a single CPU is available: * Avoid creating threads in StateDB.IntermediateRoot * Force single threaded hashing
karlb
pushed a commit
to celo-org/op-geth
that referenced
this pull request
Sep 16, 2024
When only a single CPU is available: * Avoid creating threads in StateDB.IntermediateRoot * Force single threaded hashing
sebastianst
pushed a commit
that referenced
this pull request
Sep 17, 2024
When only a single CPU is available: * Avoid creating threads in StateDB.IntermediateRoot * Force single threaded hashing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies
StateDBto execute all tasks on a single thread when there is a single CPU rather than spawning go routines to compute account storage roots in parallel. Also ensures the hasher only uses parallel mode when there are multiple CPUs available to accelerate the work.This ensures compatibility with cannon where there is only a single CPU and thread creation is not supported.